mirror of
https://github.com/containers/gvisor-tap-vsock.git
synced 2026-04-23 00:27:09 +08:00
Christophe Fergeau
61dc4e1eb2
This causes a regression in gvproxy when it's used by podman:
https://github.com/containers/podman/issues/23616
Thanks to Maciej Szlosarczyk <maciej@sosek.net> for investigating and
finding the faulty commit!
Reverting inetaf/tcpproxy commit 2862066 is a bit convoluted, as we need
to first undo the module name change (inet.af/tcpproxy ->
github.com/inetaf/tcpproxy) done in commit 600910ca
and then a go module `replace` directive to redirect the no-longer
existing inet.af/tcpproxy to the commit we want in github.com/inetaf/tcpproxy/
This way, the module name in gvisor-tap-vsock go.mod and in
github.com/inetaf/tcpproxy go.mod are the same (inet.af/tcpproxy), and
we can use older commits in this repository.
It's unclear what's causing the regression, as the commit log/PR
description/associated issue don't provide useful details:
https://github.com/inetaf/tcpproxy/commit/2862066fc2a9405880f212f71230425bdfe9950e
The best I could find is:
https://github.com/tailscale/tailscale/pull/10070
> The close in the handler sometimes occurs before the buffered data is
forwarded. The proxy could be improved to perform a half-close dance,
such that it will only mutually close once both halves are closed or
both halves error.
and https://github.com/inetaf/tcpproxy/issues/21 which seems to be the
same issue as https://github.com/inetaf/tcpproxy/pull/38 which is the
issue fixed by the commit triggering the regression.
What could be happening is that before inetaf/tcpproxy commit 2862066,
as soon as one side of the connection was closed, the other half was
also closed, while after commit 2862066, the tcpproxy code waits for
both halves of the connection to be closed. So maybe we are missing a
connection close somewhere in gvproxy's code :-/
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>