mirror of
https://github.com/bolucat/Archive.git
synced 2026-04-23 00:17:16 +08:00
github-action[bot]
73 lines
2.5 KiB
Diff
73 lines
2.5 KiB
Diff
From 23913d7d60576512c818408b0e4bc612d02af1c4 Mon Sep 17 00:00:00 2001
|
|
From: Jim Quinlan <james.quinlan@broadcom.com>
|
|
Date: Fri, 14 Feb 2025 12:39:34 -0500
|
|
Subject: [PATCH] PCI: brcmstb: Use same constant table for config space access
|
|
|
|
The constants EXT_CFG_DATA and EXT_CFG_INDEX vary by SOC. One of the
|
|
map_bus methods used these constants, the other used different constants.
|
|
Fortunately there was no problem because the SoCs that used the latter
|
|
map_bus method all had the same register constants.
|
|
|
|
Remove the redundant constants and adjust the code to use them. In
|
|
addition, update EXT_CFG_DATA to use the 4k-page based config space access
|
|
system, which is what the second map_bus method was already using.
|
|
|
|
Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
|
|
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
|
|
---
|
|
drivers/pci/controller/pcie-brcmstb.c | 14 ++++++--------
|
|
1 file changed, 6 insertions(+), 8 deletions(-)
|
|
|
|
--- a/drivers/pci/controller/pcie-brcmstb.c
|
|
+++ b/drivers/pci/controller/pcie-brcmstb.c
|
|
@@ -153,9 +153,6 @@
|
|
#define MSI_INT_MASK_SET 0x10
|
|
#define MSI_INT_MASK_CLR 0x14
|
|
|
|
-#define PCIE_EXT_CFG_DATA 0x8000
|
|
-#define PCIE_EXT_CFG_INDEX 0x9000
|
|
-
|
|
#define PCIE_RGR1_SW_INIT_1_PERST_MASK 0x1
|
|
#define PCIE_RGR1_SW_INIT_1_PERST_SHIFT 0x0
|
|
|
|
@@ -730,8 +727,8 @@ static void __iomem *brcm_pcie_map_bus(s
|
|
|
|
/* For devices, write to the config space index register */
|
|
idx = PCIE_ECAM_OFFSET(bus->number, devfn, 0);
|
|
- writel(idx, pcie->base + PCIE_EXT_CFG_INDEX);
|
|
- return base + PCIE_EXT_CFG_DATA + PCIE_ECAM_REG(where);
|
|
+ writel(idx, base + IDX_ADDR(pcie));
|
|
+ return base + DATA_ADDR(pcie) + PCIE_ECAM_REG(where);
|
|
}
|
|
|
|
static void __iomem *brcm7425_pcie_map_bus(struct pci_bus *bus,
|
|
@@ -1732,7 +1729,7 @@ static void brcm_pcie_remove(struct plat
|
|
static const int pcie_offsets[] = {
|
|
[RGR1_SW_INIT_1] = 0x9210,
|
|
[EXT_CFG_INDEX] = 0x9000,
|
|
- [EXT_CFG_DATA] = 0x9004,
|
|
+ [EXT_CFG_DATA] = 0x8000,
|
|
[PCIE_HARD_DEBUG] = 0x4204,
|
|
[PCIE_INTR2_CPU_BASE] = 0x4300,
|
|
};
|
|
@@ -1740,7 +1737,7 @@ static const int pcie_offsets[] = {
|
|
static const int pcie_offsets_bcm7278[] = {
|
|
[RGR1_SW_INIT_1] = 0xc010,
|
|
[EXT_CFG_INDEX] = 0x9000,
|
|
- [EXT_CFG_DATA] = 0x9004,
|
|
+ [EXT_CFG_DATA] = 0x8000,
|
|
[PCIE_HARD_DEBUG] = 0x4204,
|
|
[PCIE_INTR2_CPU_BASE] = 0x4300,
|
|
};
|
|
@@ -1754,8 +1751,9 @@ static const int pcie_offsets_bcm7425[]
|
|
};
|
|
|
|
static const int pcie_offsets_bcm7712[] = {
|
|
+ [RGR1_SW_INIT_1] = 0x9210,
|
|
[EXT_CFG_INDEX] = 0x9000,
|
|
- [EXT_CFG_DATA] = 0x9004,
|
|
+ [EXT_CFG_DATA] = 0x8000,
|
|
[PCIE_HARD_DEBUG] = 0x4304,
|
|
[PCIE_INTR2_CPU_BASE] = 0x4400,
|
|
};
|