zishuo/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2026-04-22 15:57:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

mobile/ebitenmobileview: accept sourceUnknown events from virtualKeyboard (#3416)

Browse Source 
Accept input events from sourceUnknown on Android when the deviceID is
virtualKeyboard (-1). This can happen especially with control keys like
backspace or DEL on certain IMEs. See linked issue for more details on
IME behavior.

Closes #3415
This commit is contained in:
tinne26
2026-03-18 19:10:09 +01:00
committed by GitHub
parent 655a6d5edf
commit 1d72ff7218
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mobile/ebitenmobileview/input_android.go
+8 -2
View File
@@ -70,11 +70,17 @@ const (
// https://developer.android.com/reference/android/view/InputDevice
const (
sourceUnknown = 0x00000000
sourceKeyboard = 0x00000101
sourceGamepad = 0x00000401
sourceJoystick = 0x01000010
)
// https://developer.android.com/reference/android/view/KeyCharacterMap#VIRTUAL_KEYBOARD
const (
virtualKeyboard = -1
)
// See https://github.com/libsdl-org/SDL/blob/47f2373dc13b66c48bf4024fcdab53cd0bdd59bb/src/joystick/android/SDL_sysjoystick.c#L71-L172
// TODO: This exceeds gamepad.SDLControllerButtonMax. Is that OK?
@@ -139,7 +145,7 @@ func OnKeyDownOnAndroid(keyCode int, unicodeChar int, source int, deviceID int)
}
case source&sourceJoystick == sourceJoystick:
// DPAD keys can come here, but they are also treated as an axis at a motion event. Ignore them.
case source&sourceKeyboard == sourceKeyboard:
case source&sourceKeyboard == sourceKeyboard, source == sourceUnknown && deviceID == virtualKeyboard:
if key, ok := androidKeyToUIKey[keyCode]; ok {
keyPressedTimes[key] = ui.Get().InputTime()
}
@@ -160,7 +166,7 @@ func OnKeyUpOnAndroid(keyCode int, source int, deviceID int) {
}
case source&sourceJoystick == sourceJoystick:
// DPAD keys can come here, but they are also treated as an axis at a motion event. Ignore them.
case source&sourceKeyboard == sourceKeyboard:
case source&sourceKeyboard == sourceKeyboard, source == sourceUnknown && deviceID == virtualKeyboard:
if key, ok := androidKeyToUIKey[keyCode]; ok {
keyReleasedTimes[key] = ui.Get().InputTime()
}