mirror of
https://github.com/dunglas/frankenphp.git
synced 2026-04-23 00:37:20 +08:00
25ed020036
Closes #83 #880 #1286. Working patch for Windows support. Supports linking to the [official PHP release (TS version)](https://www.php.net/downloads.php). Includes some work from #1286 (thanks @TenHian!!) This patch allows using Visual Studio to compile the cgo code. To do so, it must be compiled with Go 1.26 (RC) with the following setup: ```powershell winget install -e --id Microsoft.VisualStudio.2022.Community --override "--passive --wait --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.Llvm.Clang --includeRecommended" winget install -e --id GoLang.Go $env:PATH += ';C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\Llvm\bin' cd c:\ gh repo clone microsoft/vcpkg .\vcpkg\bootstrap-vcpkg.bat .\vcpkg\vcpkg install pthreads brotli # build watcher Invoke-WebRequest -Uri "https://github.com/e-dant/watcher/releases/download/0.14.3/x86_64-pc-windows-msvc.tar" -OutFile "$env:TEMP\watcher.tar" tar -xf "$env:TEMP\watcher.tar" -C C:\ Rename-Item -Path "C:\x86_64-pc-windows-msvc" -NewName "watcher-x86_64-pc-windows-msvc" Remove-Item "$env:TEMP\watcher.tar" # download php Invoke-WebRequest -Uri "https://downloads.php.net/~windows/releases/archives/php-8.5.1-Win32-vs17-x64.zip" -OutFile "$env:TEMP\php.zip" Expand-Archive -Path "$env:TEMP\php.zip" -DestinationPath "C:\" Remove-Item "$env:TEMP\php.zip" # download php development package Invoke-WebRequest -Uri "https://downloads.php.net/~windows/releases/archives/php-devel-pack-8.5.1-Win32-vs17-x64.zip" -OutFile "$env:TEMP\php-devel.zip" Expand-Archive -Path "$env:TEMP\php-devel.zip" -DestinationPath "C:\" Remove-Item "$env:TEMP\php-devel.zip" $env:GOTOOLCHAIN = 'go1.26rc1' $env:CC = 'clang' $env:CXX = 'clang++' $env:CGO_CFLAGS = "-I$env:C:\vcpkg\installed\x64-windows\include -IC:\watcher-x86_64-pc-windows-msvc -IC:\php-8.5.1-devel-vs17-x64\include -IC:\php-8.5.1-devel-vs17-x64\include\main -IC:\php-8.5.1-devel-vs17-x64\include\TSRM -IC:\php-8.5.1-devel-vs17-x64\include\Zend -IC:\php-8.5.1-devel-vs17-x64\include\ext" $env:CGO_LDFLAGS = '-LC:\vcpkg\installed\x64-windows\lib -lbrotlienc -LC:\watcher-x86_64-pc-windows-msvc -llibwatcher-c -LC:\php-8.5.1-Win32-vs17-x64 -LC:\php-8.5.1-devel-vs17-x64\lib -lphp8ts -lphp8embed' # clone frankenphp and build git clone -b windows https://github.com/php/frankenphp.git cd frankenphp\caddy\frankenphp go build -ldflags '-extldflags="-fuse-ld=lld"' -tags nowatcher,nobadger,nomysql,nopgx # Tests $env:PATH += ";$env:VCPKG_ROOT\installed\x64-windows\bin;C:\watcher-x86_64-pc-windows-msvc";C:\php-8.5.1-Win32-vs17-x64" "opcache.enable=0`r`nopcache.enable_cli=0" | Out-File -Encoding ascii php.ini $env:PHPRC = Get-Location go test -ldflags '-extldflags="-fuse-ld=lld"' -tags nowatcher,nobadger,nomysql,nopgx . ``` TODO: - [x] Fix remaining skipped tests (scaling and watcher) - [x] Test if the watcher mode works as expected - [x] Automate the build with GitHub Actions --------- Signed-off-by: Marc <m@pyc.ac> Co-authored-by: Kévin Dunglas <kevin@dunglas.dev> Co-authored-by: DubbleClick <m@pyc.ac>
180 lines
5.4 KiB
YAML
180 lines
5.4 KiB
YAML
---
|
|
name: Tests
|
|
concurrency:
|
|
cancel-in-progress: true
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
on:
|
|
pull_request:
|
|
branches:
|
|
- main
|
|
paths-ignore:
|
|
- "docs/**"
|
|
push:
|
|
branches:
|
|
- main
|
|
paths-ignore:
|
|
- "docs/**"
|
|
permissions:
|
|
contents: read
|
|
env:
|
|
GOTOOLCHAIN: local
|
|
GOEXPERIMENT: cgocheck2
|
|
jobs:
|
|
tests-linux:
|
|
name: Tests (Linux, PHP ${{ matrix.php-versions }})
|
|
runs-on: ubuntu-latest
|
|
continue-on-error: false
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include:
|
|
- php-versions: "8.2"
|
|
- php-versions: "8.3"
|
|
- php-versions: "8.4"
|
|
- php-versions: "8.5"
|
|
env:
|
|
GOMAXPROCS: 10
|
|
LIBRARY_PATH: ${{ github.workspace }}/watcher/target/lib
|
|
GOFLAGS: "-tags=nobadger,nomysql,nopgx"
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
with:
|
|
persist-credentials: false
|
|
- uses: actions/setup-go@v6
|
|
with:
|
|
go-version: "1.26"
|
|
cache-dependency-path: |
|
|
go.sum
|
|
caddy/go.sum
|
|
- uses: shivammathur/setup-php@v2
|
|
with:
|
|
php-version: ${{ matrix.php-versions }}
|
|
ini-file: development
|
|
coverage: none
|
|
tools: none
|
|
env:
|
|
phpts: ts
|
|
debug: true
|
|
- name: Install e-dant/watcher
|
|
uses: ./.github/actions/watcher
|
|
- name: Set CGO flags
|
|
run: echo "CGO_CFLAGS=-I${PWD}/watcher/target/include $(php-config --includes)" >> "${GITHUB_ENV}"
|
|
- name: Build
|
|
run: go build
|
|
- name: Build testcli binary
|
|
working-directory: internal/testcli/
|
|
run: go build
|
|
- name: Compile library tests
|
|
run: go test -race -v -x -c
|
|
- name: Run library tests
|
|
run: ./frankenphp.test -test.v
|
|
- name: Run Caddy module tests
|
|
working-directory: caddy/
|
|
run: go test -race -v ./...
|
|
- name: Run Fuzzing Tests
|
|
working-directory: caddy/
|
|
run: go test -fuzz FuzzRequest -fuzztime 20s
|
|
- name: Build the server
|
|
working-directory: caddy/frankenphp/
|
|
run: go build
|
|
- name: Start the server
|
|
working-directory: testdata/
|
|
run: sudo ../caddy/frankenphp/frankenphp start
|
|
- name: Run integrations tests
|
|
run: ./reload_test.sh
|
|
- name: Lint Go code
|
|
uses: golangci/golangci-lint-action@v9
|
|
if: matrix.php-versions == '8.5'
|
|
with:
|
|
version: latest
|
|
- name: Ensure go.mod is tidy
|
|
if: matrix.php-versions == '8.5'
|
|
run: go mod tidy -diff
|
|
- name: Ensure caddy/go.mod is tidy
|
|
if: matrix.php-versions == '8.5'
|
|
run: go mod tidy -diff
|
|
working-directory: caddy/
|
|
integration-tests:
|
|
name: Integration Tests (Linux, PHP ${{ matrix.php-versions }})
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
php-versions: ["8.3", "8.4", "8.5"]
|
|
env:
|
|
XCADDY_GO_BUILD_FLAGS: "-tags=nobadger,nomysql,nopgx"
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
with:
|
|
persist-credentials: false
|
|
- uses: actions/setup-go@v6
|
|
with:
|
|
go-version: "1.26"
|
|
cache-dependency-path: |
|
|
go.sum
|
|
caddy/go.sum
|
|
- uses: shivammathur/setup-php@v2
|
|
with:
|
|
php-version: ${{ matrix.php-versions }}
|
|
ini-file: development
|
|
coverage: none
|
|
tools: none
|
|
env:
|
|
phpts: ts
|
|
debug: true
|
|
- name: Install PHP development libraries
|
|
run: sudo apt-get update && sudo apt-get install -y libkrb5-dev libsodium-dev libargon2-dev
|
|
- name: Install xcaddy
|
|
run: go install github.com/caddyserver/xcaddy/cmd/xcaddy@latest
|
|
- name: Download PHP sources
|
|
run: |
|
|
PHP_VERSION=$(php -r "echo PHP_VERSION;")
|
|
wget -q "https://www.php.net/distributions/php-${PHP_VERSION}.tar.gz"
|
|
tar xzf "php-${PHP_VERSION}.tar.gz"
|
|
echo "GEN_STUB_SCRIPT=${PWD}/php-${PHP_VERSION}/build/gen_stub.php" >> "${GITHUB_ENV}"
|
|
- name: Set CGO flags
|
|
run: |
|
|
echo "CGO_CFLAGS=$(php-config --includes)" >> "${GITHUB_ENV}"
|
|
echo "CGO_LDFLAGS=$(php-config --ldflags) $(php-config --libs)" >> "${GITHUB_ENV}"
|
|
- name: Run integration tests
|
|
working-directory: internal/extgen/
|
|
run: go test -tags integration -v -timeout 30m
|
|
tests-mac:
|
|
name: Tests (macOS, PHP 8.5)
|
|
runs-on: macos-latest
|
|
env:
|
|
HOMEBREW_NO_AUTO_UPDATE: 1
|
|
GOFLAGS: "-tags=nowatcher,nobadger,nomysql,nopgx"
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
with:
|
|
persist-credentials: false
|
|
- uses: actions/setup-go@v6
|
|
with:
|
|
go-version: "1.26"
|
|
cache-dependency-path: |
|
|
go.sum
|
|
caddy/go.sum
|
|
- uses: shivammathur/setup-php@v2
|
|
with:
|
|
php-version: 8.5
|
|
ini-file: development
|
|
coverage: none
|
|
tools: none
|
|
env:
|
|
phpts: ts
|
|
debug: true
|
|
- name: Set Set CGO flags
|
|
run: |
|
|
{
|
|
echo "CGO_CFLAGS=-I/opt/homebrew/include/ $(php-config --includes)"
|
|
echo "CGO_LDFLAGS=-L/opt/homebrew/lib/ $(php-config --ldflags) $(php-config --libs)"
|
|
} >> "${GITHUB_ENV}"
|
|
- name: Build
|
|
run: go build -tags nowatcher
|
|
- name: Run library tests
|
|
run: go test -tags nowatcher -race -v ./...
|
|
- name: Run Caddy module tests
|
|
working-directory: caddy/
|
|
run: go test -race -v ./...
|